feat(search): process [C-h] and [C-?] as representations of backspace #1857
+15
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the conventional terminal protocol, Backspace can be transmitted as the code \x08 or \x7F depending on the terminal. Ctrl+Backspace can also be transmitted as the code \x08 or \x7F. These overlap with the code for Ctrl+H and Ctrl+?. The crossterm library does not try to handle these terminal dependencies (probably because it is hard to resolve it perfectly). To provide a consistent experience among terminals, we assign to C-h and C-? the same feature as backspace. Note: The crossterm seems to produce Ctrl+Backspace only in the extended keyboard protocol, so we can trust crossterm particularly for Ctrl+Backspace. For this reason, we keep the feature of removing a backward word by Ctrl+Backspace. atuinsh#1753
ellie
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1753
As discussed in #1753, I think this should ideally be fixed in
crossterm, but there are general limitations by the terminal protocols and the support by the terminals in the market. I here instead suggest solving this at Atuin's side. The description is found in the commit message and also in a code comment.Checks